[go_router_builder] Update route_config.dart to allow percent-encoding path#11291
[go_router_builder] Update route_config.dart to allow percent-encoding path#11291AlexeyBukin wants to merge 1 commit intoflutter:mainfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Code Review
This pull request attempts to fix an issue with percent-encoding in path patterns by using Uri.encodeFull. While this works for spaces, it's an incomplete solution as it doesn't handle other characters that should be encoded in path segments (like +). I've suggested a more robust approach that correctly encodes all static path segments while leaving parameter placeholders untouched.
| }), | ||
| ); | ||
| final String location = patternToPath(_basePathForLocation, pathParameters); | ||
| final String location = patternToPath(Uri.encodeFull(_basePathForLocation), pathParameters); |
There was a problem hiding this comment.
Using Uri.encodeFull is an improvement for paths with spaces, but it's not a complete solution. It doesn't encode other characters that should be percent-encoded in a path segment (like +), which can lead to malformed or ambiguous URLs.
A more robust approach is to split the path into segments, encode each static segment individually, and then rejoin them. This ensures that all special characters in static path segments are correctly encoded, while parameter placeholders are preserved for patternToPath.
| final String location = patternToPath(Uri.encodeFull(_basePathForLocation), pathParameters); | |
| final String location = patternToPath(_basePathForLocation.split('/').map((String s) => s.startsWith(':') ? s : Uri.encodeComponent(s)).join('/'), pathParameters); |
|
Basically we @TypedGoRoute<ZoneRoute>(path: '/прывітанне/:id') // pass id = `пяты`
...Resolving before pr: Resolving after pr: |
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2