Skip to content

[video_player] Upgrade video_player to 2.11.1#975

Merged
xiaowei-guan merged 4 commits intoflutter-tizen:masterfrom
gin7773:update/video_player
Apr 2, 2026
Merged

[video_player] Upgrade video_player to 2.11.1#975
xiaowei-guan merged 4 commits intoflutter-tizen:masterfrom
gin7773:update/video_player

Conversation

@gin7773
Copy link
Copy Markdown
Contributor

@gin7773 gin7773 commented Apr 1, 2026

Fix #969

Main changes:

  • Update video_player to 2.11.1.
  • Update video_player_platform_interface to 6.6.0.
  • Updates minimum supported SDK version to Flutter 3.38/Dart 3.10.

@gin7773
Copy link
Copy Markdown
Contributor Author

gin7773 commented Apr 1, 2026

#969

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates video_player_tizen to version 2.5.10, bumps dependencies for video_player and video_player_platform_interface, and increases the minimum supported SDK versions for Flutter and Dart. It also includes regenerated Pigeon code and updates the implementation to use prefixed imports for the platform interface. Feedback indicates that the Flutter version 3.38.0 is likely a typo as it is currently unreleased, and that the version bump should be minor (2.6.0) rather than patch to comply with Semantic Versioning for SDK constraint changes. Additionally, the environment constraints in the example package require synchronization with the main package.

@gin7773 gin7773 force-pushed the update/video_player branch from cb72856 to 5b84bf9 Compare April 1, 2026 07:44
@xiaowei-guan xiaowei-guan merged commit f7f22fb into flutter-tizen:master Apr 2, 2026
6 checks passed
@JSUYA
Copy link
Copy Markdown
Member

JSUYA commented Apr 2, 2026

@gin7773
There are new interfaces added in 6.6.0 and 6.5.0 of video_player_platform_interface.
Is it impossible to implement these interfaces in Tizen?

@gin7773
Copy link
Copy Markdown
Contributor Author

gin7773 commented Apr 2, 2026

@gin7773 There are new interfaces added in 6.6.0 and 6.5.0 of video_player_platform_interface. Is it impossible to implement these interfaces in Tizen?

Thanks for the heads-up. Upon closer inspection of the APIs in player.h, here are my findings:

  1. setAllowBackgroundPlayback(added in 6.5.0) cannot be implemented as here lacks the necessary APIs.
  2. For getAudioTracks(added in 6.6.0), full support is not feasible because the VideoAudioTrack.label cannot be retrieved.
    If we are to include this interface, we will need a workaround for the VideoAudioTrack.label field, for example, by using the uppercase VideoAudioTrack.language as the label value. If this is acceptable, I will submit the code as soon as possible.

@JSUYA
Copy link
Copy Markdown
Member

JSUYA commented Apr 2, 2026

2. For getAudioTracks(added in 6.6.0), full support is not feasible because the VideoAudioTrack.label cannot be retrieved.
If we are to include this interface, we will need a workaround for the VideoAudioTrack.label field, for example, by using the uppercase VideoAudioTrack.language as the label value. If this is acceptable, I will submit the code as soon as possible.

If a suitable API does not exist, you do not have to implement it.
However, you should add appropriate content to the Limitations section of the README. Please update the README.
https://github.com/flutter-tizen/plugins/tree/master/packages/video_player

@gin7773
Copy link
Copy Markdown
Contributor Author

gin7773 commented Apr 3, 2026

  1. For getAudioTracks(added in 6.6.0), full support is not feasible because the VideoAudioTrack.label cannot be retrieved.
    If we are to include this interface, we will need a workaround for the VideoAudioTrack.label field, for example, by using the uppercase VideoAudioTrack.language as the label value. If this is acceptable, I will submit the code as soon as possible.

If a suitable API does not exist, you do not have to implement it. However, you should add appropriate content to the Limitations section of the README. Please update the README. https://github.com/flutter-tizen/plugins/tree/master/packages/video_player

Thanks. I've updated README.md.#978

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[video_player_tizen] Upgrade to 2.11.1

3 participants