Conversation
|
Looks like the base branch was incorrectly set as |
|
|
||
| - name: Install tools | ||
| run: | | ||
| sudo apt-get update && sudo apt-get install -y debian-archive-keyring |
There was a problem hiding this comment.
Not sure how this package should be handled when using Nix. Will Nix pick it up from the host system? Or maybe Nix has its own package with a similar purpose?
There was a problem hiding this comment.
It's not needed anymore on main, but i did things differently
|
|
||
| - name: Build ${{ matrix.image }} image | ||
| run: | | ||
| umask 022 |
There was a problem hiding this comment.
This was needed when building without Nix to match Debian's default umask while building on Ubuntu. With Nix I'm not sure if it is needed.
|
Nvm my previous comment. Now that I'm taking a good look at how the CI is implemented on the main branch, I'm noticing some issues, but none of them are new issues introduced by your branch. Let's just merge this for now and then I'll clean up the workflow yaml later. |
pablin-10
deleted the
pablo/box-49-add-repro-test-ci-on-main-for-flashbox-images
branch
3 participants
No description provided.