Conversation
alexhulbert
changed the title
There was a problem hiding this comment.
suggestion:
can common be renamed to _common (so that it's not lost in the mix of real modules)?
There was a problem hiding this comment.
i talked with mateusz Moe and Ilya about this a while back, and the consensus was that we shouldn't have a distinction between "real" modules and "shared" modules since (evidently) there are certain products coming down the pipe that may just be combinations of two shares modules
There was a problem hiding this comment.
can you provide a (realistic) example of such product (that is a combination of 2+ shared modules)?
There was a problem hiding this comment.
suggestion:
also, maybe shared should be common (to keep things consistent)
There was a problem hiding this comment.
I made it different specifically to not keep things consistent. that way you know just from the tab name in vim or vscode or whatever you use to edit files whether you're editing shared code or a particular product
| │ ├── flashbox-l1.conf | ||
| │ ├── flashbox-l2.conf | ||
| │ └── tdx-dummy.conf | ||
| ├── buildernet/ # BuilderNet |
There was a problem hiding this comment.
Don't think we have buildernet/
|
Really like the new structure <3 |
| Include=modules/flashbox/flashbox-l1/mkosi.conf | ||
|
|
||
| [Config] | ||
| Profiles=azure,gcp |
There was a problem hiding this comment.
issue:
cloud-specific profiles mustn't be mixed
3 participants
Summary
base/->shared/,kernel/->shared/kernel/bob-common/->modules/flashbox/common/,bob-l1/->modules/flashbox/flashbox-l1/,bob-l2/->modules/flashbox/flashbox-l2/,tdx-dummy/->modules/tdx-dummy/*.conf->images/*.conf(renamed bob to flashbox)verify/->scripts/verification/No files under
mkosi.extra/were modified, only moved. The only change that affected the image isIMAGE_IDin/etc/os-release(bob-l1-dev→flashbox-l1-dev), which is set by the--image-idflag at build time.Migration
Run
make build IMAGE=flashbox-l1instead ofmake build IMAGE=bob-1same for dev builds and bob-l2Test plan
make build-dev IMAGE=flashbox-l1succeedsIMAGE_IDinos-release)