Open
Conversation
6aefb06 to
cafcf2c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds an
attributesparameter to the@filamentScriptsBlade directive andrenderScripts(), allowing arbitrary HTML attributes to be applied to every rendered<script>tag including thewindow.filamentDatablock.Usage
Or globally via
config/filament.php:Usage Case?
As an Example Cloudflare Rocket Loader defers JavaScript execution by default, which breaks Filament forms in blade, While admin panel could be filtered or bypassed using cloudflare rules, it may be difficult to bypass every single uri, you are using filament form in. Cloudflare requires
data-cfasync="false"on every<script>tag to opt out. Without this, users had to override the entire@filamentScriptsdirective manually.Changes
I tried to make the minimal impacts or changes possible, so the changes are:
AssetManager::renderScripts()now acceptsarray $attributes = [], merged withconfig('filament.scripts.attributes')(inline wins on conflict)Js::getExtraAttributesHtml()supports integer-keyed (valueless) attributes e.g.['async']renders asasyncnot0="async"<script src=...>tags and thewindow.filamentDatainline blockTests