Skip to content

feat: get item index in itemLabel on Repeater #19296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pintend wants to merge 1 commit into from
Closed

feat: get item index in itemLabel on Repeater #19296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/forms/resources/views/components/repeater/index.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@
>
@foreach ($items as $itemKey => $item)
@php
$itemLabel = $getItemLabel($itemKey);
$itemLabel = $getItemLabel($itemKey, $loop->iteration);
Copy link
Member

@People-Sea People-Sea Feb 18, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be $loop->index instead? Since the injected parameter is named $index, it should start at 0 to match convention.

$visibleExtraItemActions = array_filter(
$extraItemActions,
fn (Action $action): bool => $action(['item' => $itemKey])->isVisible(),
Expand Down
3 changes: 2 additions & 1 deletion packages/forms/src/Components/Repeater.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1191,7 +1191,7 @@ public function getCachedExistingRecords(): Collection
));
}

public function getItemLabel(string $key): string | Htmlable | null
public function getItemLabel(string $key, ?int $index = null): string | Htmlable | null
{
$container = $this->getChildSchema($key);

Expand All @@ -1202,6 +1202,7 @@ public function getItemLabel(string $key): string | Htmlable | null
'schema' => $container,
'state' => $container->getStateSnapshot(),
'uuid' => $key,
'index' => $index,
]);
}

Expand Down