Conversation
Ignoring x-bind:style
Initialize commitThis commit creates a new API for developer to:
Nonces to current elements commitTo all style and script elements defined in Filament Blade templates a nonce has been added. Simple inlines to elements commitSimple inline style attributes has been moved to their own style elements with nonce. Most classes are either internal (predefined) or unique (randomly generated, not expected to be used more than once). This commit does not edit |
danharrin
left a comment
There was a problem hiding this comment.
As I said here #7032 (reply in thread), I don't think we should focus on CSP style support: it looks like most of the changes here are related to that. I do not think it's supported in Livewire / Alpine / TipTap. Should we not be focusing on inline scripts?
|
While making the library CSP compliant, I am trying to solve all issues that both are now relevant now and may be relevant in the future. I can undo the commit that focuses on inline styles tho. The next steps will be focused on inline scripts, x-data attribute and pushing current CSP nonce via 'livewire/update' requests. |
|
Please undo all style-related changes. While I appreciate the endeavour to solve everything, this will already be a large PR that is difficult to safely review, and including styles is going to increase the surface area when they aren't even able to be used. |
|
Hi @4513, any update on this? Just want to make sure this doesn't go stale, or I would rather the PR was opened once it was ready for review. No expectations to finish if you don't want to, but if not I would rather close it. Thanks. |
|
@4513 Need any help? Perhaps if we could divide the work we can make this work together? |
Description
As discussed in #7032, this PR adds a support for CSP.
The PR is in WIP state as more commits will be made.
Visual changes
There are no visual changes expected to happen - an end user must not notice any change.
Functional changes
composer cscommand.