Add: Http Proxy Options When Downloading Drivers#943
Open
michal0000000 wants to merge 4 commits intofalcosecurity:mainfrom
Open
Add: Http Proxy Options When Downloading Drivers#943michal0000000 wants to merge 4 commits intofalcosecurity:mainfrom
michal0000000 wants to merge 4 commits intofalcosecurity:mainfrom
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: michal0000000 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
Welcome @michal0000000! It looks like this is your first PR to falcosecurity/falcoctl 🎉 |
Bumps the actions group with 1 update: [aws-actions/amazon-ecr-login](https://github.com/aws-actions/amazon-ecr-login). Updates `aws-actions/amazon-ecr-login` from 2.0.2 to 2.1.0 - [Release notes](https://github.com/aws-actions/amazon-ecr-login/releases) - [Changelog](https://github.com/aws-actions/amazon-ecr-login/blob/main/CHANGELOG.md) - [Commits](aws-actions/amazon-ecr-login@c962da2...261fc3d) --- updated-dependencies: - dependency-name: aws-actions/amazon-ecr-login dependency-version: 2.1.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: actions ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: michal000 <michal000@rpi5>
Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.271.0 to 0.272.0. - [Release notes](https://github.com/googleapis/google-api-go-client/releases) - [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md) - [Commits](googleapis/google-api-go-client@v0.271.0...v0.272.0) --- updated-dependencies: - dependency-name: google.golang.org/api dependency-version: 0.272.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: michal000 <michal000@rpi5>
Signed-off-by: michal000 <michal000@rpi5>
Signed-off-by: michal0000000 <111810032+michal0000000@users.noreply.github.com>
Author
Member
|
Hi @michal0000000, CI checks failed. PTAL Did you validate this PR fixes somehow the issue you mentioned? The http.DefaultTransport used by the driver, index, and artifacts download paths already observes HTTP(S)_PROXY. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/kind feature
/area cli
What this PR does / why we need it:
Adds CLI support for configuring proxy usage in the default HTTP client used for driver downloads.
Which issue(s) this PR fixes:
Contributes to falcosecurity/falco#3339 by providing the underlying CLI support in falcoctl.