Add allocation size overflow checks in ZDICT_trainBuffer_legacy()#4616
Open
nidu-ninja wants to merge 1 commit intofacebook:devfrom
Open
Add allocation size overflow checks in ZDICT_trainBuffer_legacy()#4616nidu-ninja wants to merge 1 commit intofacebook:devfrom
nidu-ninja wants to merge 1 commit intofacebook:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR adds overflow checks to several memory allocations in
ZDICT_trainBuffer_legacy() within zdict.c.
The function previously computed allocation sizes using expressions such as:
(bufferSize + N) * sizeof(type)
nbFiles * sizeof(type)
without validating whether the intermediate arithmetic could overflow size_t.