Validate ds range early; clear error for out-of-bounds datetime64[ns]#2690
Validate ds range early; clear error for out-of-bounds datetime64[ns]#2690NikhithReddyScripts wants to merge 1 commit intofacebook:mainfrom
Conversation
|
Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Summary
Prophet crashed when
dscontains dates outside pandas datetime64[ns] range. Example: 3969-12-02.Root cause
preprocess()castsdsviapd.to_datetime(...), which forces ns precision and raisesOutOfBoundsDatetimedeep in pandas.Fix
Add
_validate_ds_ns_range(df["ds"])at the start ofpreprocess(). It parses to plaindatewithout pandas and raises a clear ValueError with the supported range (1677-09-21 to 2262-04-11) and the first offending value.Tests
test_in_range_okverifies normal fit with valid dates.test_out_of_range_raisesasserts ValueError and message substringdatetime64[ns].Behavior
No changes for valid inputs. Out-of-range data now gets an immediate, actionable error instead of a pandas traceback.
Fixes #2689.