Skip to content

Remove deprecated ObjectiveThreshold assert_is_instance checks #5105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mgrange1998 wants to merge 1 commit into from
+3 −9
Closed

Remove deprecated ObjectiveThreshold assert_is_instance checks #5105

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions ax/storage/sqa_store/encoder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,7 @@
OptimizationConfig,
PreferenceOptimizationConfig,
)
from ax.core.outcome_constraint import (
ObjectiveThreshold,
OutcomeConstraint,
ScalarizedOutcomeConstraint,
)
from ax.core.outcome_constraint import OutcomeConstraint, ScalarizedOutcomeConstraint
from ax.core.parameter import (
ChoiceParameter,
DerivedParameter,
Expand Down Expand Up @@ -772,7 +768,7 @@ def scalarized_outcome_constraint_to_sqa(

def objective_threshold_to_sqa(
self,
objective_threshold: ObjectiveThreshold,
objective_threshold: OutcomeConstraint,
experiment_metrics: dict[str, Metric] | None = None,
) -> SQAMetric:
"""Convert Ax OutcomeConstraint to SQLAlchemy."""
Expand Down Expand Up @@ -847,9 +843,7 @@ def optimization_config_to_sqa(
):
for threshold in optimization_config.objective_thresholds:
threshold_sqa = self.objective_threshold_to_sqa(
objective_threshold=assert_is_instance(
threshold, ObjectiveThreshold
),
objective_threshold=threshold,
experiment_metrics=experiment_metrics,
)
metrics_sqa.append(threshold_sqa)
Expand Down
Loading