This repository was archived by the owner on Jan 3, 2023. It is now read-only.
Open
Conversation
Also add a prompt when navigating away from a page with unsaved changes
editors/example.php
Outdated
Contributor
There was a problem hiding this comment.
I don't like going overboard with OO principles but I think it makes sense to make an Editor interface here that classes have to implement.
add_generic_weekly.php
Outdated
Contributor
There was a problem hiding this comment.
do we also wanna escape this?
Contributor
|
lgtm, @lozzd wanna take a look here, since you know the overall architecture of the app better than me? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While this works, I'm not sure if this is the best approach. It might be better to stick all the configuration and logic inside
base.php, as it'd be more likely that someone would implement a newprovider/*than a new editor.Thoughts?