fix: read exactly M values from channel#5447
Open
sbackend123 wants to merge 1 commit intomasterfrom
Open
Conversation
acud
requested changes
Apr 27, 2026
acud
approved these changes
Apr 27, 2026
martinconic
approved these changes
Apr 28, 2026
akrem-chabchoub
approved these changes
Apr 28, 2026
gacevicljubisa
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Read exactly M values from channel instead of reading "forever", which leads to deadlock in really seldom cases, which happen in mostly in CI
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
runStrategyassumes that while consuming results fromc, one of the two exit conditions will always become true before reads are exhausted. Because of that assumption, the previous loop usedfor range c(which only terminates when c is closed).Why this can deadlock
In the DATA -> RACE fallback path, some DATA-owned shard fetches may still be finishing while RACE starts.
RACE can include data shard indices whose waits[i] is not closed yet; for those indices, fetch takes the fly=false path and waits on waits[i].
For a successful DATA fetch, the operation order is:
There is a small window between (1) and (2):
c,runStrategycan consume that last value fromc,fetchedCntmay still be stale for that check.If this happens on the last available message in
c, neither exit condition may trigger in that iteration, and the next read blocks forever (no more writers, channel not closed).Related Issue (Optional)
Screenshots (if appropriate):
AI Disclosure