Skip to content

Remove liquidity migration update from predeploy OptimismMintableERC20Factory#683

Open
emhane wants to merge 12 commits intomainfrom
emhane/rm-liquidity-migration
Open

Remove liquidity migration update from predeploy OptimismMintableERC20Factory#683
emhane wants to merge 12 commits intomainfrom
emhane/rm-liquidity-migration

Conversation

@emhane
Copy link
Copy Markdown
Contributor

@emhane emhane commented Apr 24, 2025

Closes #633

The issue didn't permalink the affected part of this codebase, so I took my best guess. Let me know if I interpreted the issue incorrectly.

@emhane emhane added H-interop Hardfork: change planned for Interop upgrade U-smart-contract Upgrade: involving changes to smart contracts C-debt Category: debt labels Apr 24, 2025
@emhane emhane requested review from a team as code owners April 24, 2025 20:05
@emhane emhane changed the title Remove predeploy OptimismMintableERC20Factory Remove predeploy OptimismMintableERC20Factory Apr 24, 2025
tynes
tynes previously requested changes Apr 28, 2025
Copy link
Copy Markdown
Contributor

@tynes tynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on, we shouldn't fully delete the text but instead move it like mentioned in #633 (comment)

@emhane
Copy link
Copy Markdown
Contributor Author

emhane commented Apr 28, 2025

Thanks for taking this on, we shouldn't fully delete the text but instead move it like mentioned in #633 (comment)

ah, I missed that description, apologies. will do.

@emhane emhane changed the title Remove predeploy OptimismMintableERC20Factory Remove liquidity migration update from predeploy OptimismMintableERC20Factory Apr 28, 2025
@emhane emhane requested a review from tynes April 28, 2025 19:42
@maurelian maurelian enabled auto-merge (squash) February 3, 2026 14:52
Copy link
Copy Markdown
Contributor

@maurelian maurelian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The requested changes have been satisfied. Approving.

@maurelian maurelian dismissed tynes’s stale review February 3, 2026 14:55

Request is satisfied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-debt Category: debt H-interop Hardfork: change planned for Interop upgrade U-smart-contract Upgrade: involving changes to smart contracts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Interop Predeploys Spec Includes Unreleased Predeploys

3 participants