test(contracts): improve DataAvailabilityChallenge coverage and quality

[devin-ai-integration]

Summary

Mechanical improvements to test/L1/DataAvailabilityChallenge.t.sol to increase coverage and test quality while preserving all existing behavior.

Fuzz conversions (focused value → fuzz over a meaningful range):

• test_setResolverRefundPercentage_invalidResolverRefundPercentage_reverts — fuzz over the full invalid range [101, type(uint256).max] instead of just 101.
• test_challenge_beforeChallengeWindow_reverts — fuzz the number of blocks before the challenged block.
• test_challenge_afterChallengeWindow_reverts — fuzz the number of blocks after the challenge window closes.
• test_resolve_afterResolveWindow_reverts — fuzz the number of blocks past the resolve window.
• test_unlockBond_resolveWindowNotClosed_reverts — fuzz the number of blocks still inside the resolve window.

New coverage:

• DataAvailabilityChallenge_Initialize_Test::testFuzz_initialize_alreadyInitialized_reverts — verifies the proxy cannot be re-initialized.
• DataAvailabilityChallenge_Challenge_Test::testFuzz_challenge_unknownCommitmentType_reverts — exercises the validateCommitment revert path through challenge().
• DataAvailabilityChallenge_ComputeCommitmentKeccak256_Test::testFuzz_computeCommitmentKeccak256_succeeds — covers the free function at the bottom of the source file (prefix byte + keccak256).

Naming/convention fixes:

• test_withdraw_fails_reverts → test_withdraw_withdrawalFailed_reverts (use outcome reverts with a descriptive scenario).
• test_unlockBond_expiredChallengeTwice_fails → test_unlockBond_expiredChallengeTwice_succeeds (the second unlockBond does not revert, it is a no-op).

Net: 37 tests passing (up from 32), no tests removed.

Review & Testing Checklist for Human

• Confirm the fuzz bounds are meaningful (e.g. _blocksAfter ∈ [1, type(uint128).max] for the challenge/resolve window tests).
• Sanity-check the new testFuzz_initialize_alreadyInitialized_reverts — it asserts "Initializable: contract is already initialized" against the proxy-deployed instance.
• Verify the _sliceTail assembly helper in ComputeCommitmentKeccak256_Test does the right thing (it loads the 32 bytes following the length word, i.e. bytes [1..33) of the 33-byte commitment).

Notes

• Ran forge fmt, just build-dev, just lint-check, and just test-dev --match-path test/L1/DataAvailabilityChallenge.t.sol locally — all pass.
• No changes to src/L1/DataAvailabilityChallenge.sol.

Link to Devin session: https://app.devin.ai/sessions/5b84a26033914e1fab9bd641fbd72349
Requested by: @aliersh

[devin-ai-integration]

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

• Address comments on this PR that start with 'DevinAI' or '@devin'.
• Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

• Disable automatic comment and CI monitoring

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.0%. Comparing base (657d668) to head (5ac3897).

Additional details and impacted files

@@            Coverage Diff             @@
##           develop   #20168     +/-   ##
==========================================
+ Coverage     75.8%    82.0%   +6.1%     
==========================================
  Files          183      128     -55     
  Lines        10536     6501   -4035     
==========================================
- Hits          7995     5335   -2660     
+ Misses        2397     1166   -1231     
+ Partials       144        0    -144     

Flag	Coverage Δ
cannon-go-tests-64	?
contracts-bedrock-tests	82.0% <ø> (+0.2%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 57 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.