feat(op-reth): register eth_config RPC endpoint#20158
Open
feat(op-reth): register eth_config RPC endpoint#20158
Conversation
88fb3eb to
515cf81
Compare
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
ed74e5f to
8ef1cd9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## develop #20158 +/- ##
===========================================
- Coverage 75.8% 0.5% -75.3%
===========================================
Files 183 486 +303
Lines 10536 61736 +51200
===========================================
- Hits 7987 320 -7667
- Misses 2405 61416 +59011
+ Partials 144 0 -144
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Wire EthConfigHandler into OpAddOns so the eth_config method (EIP-7910) is served on the eth namespace. Extend the generic bounds on the NodeAddOns and RethRpcAddOns impls to satisfy EthConfigHandler::new: ChainSpec must also implement Hardforks (OpHardforks only implies EthereumHardforks), and the primitives' header must implement HeaderMut so per-fork configs can be built by cloning and retiming the latest header. Implement HeaderMut for the custom-node example's CustomHeader so the example keeps compiling. Add an integration test in crates/node/tests/it/rpc.rs that launches an OpNode against BASE_MAINNET and calls eth_config via the jsonrpsee HTTP client, verifying the endpoint is wired up. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
8ef1cd9 to
85c6f19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wire EthConfigHandler into OpAddOns so the eth_config method (EIP-7910) is served on the eth namespace. Extend the generic bounds on the NodeAddOns and RethRpcAddOns impls to satisfy EthConfigHandler::new: ChainSpec must also implement Hardforks (OpHardforks only implies EthereumHardforks), and the primitives' header must implement HeaderMut so per-fork configs can be built by cloning and retiming the latest header.
Implement HeaderMut for the custom-node example's CustomHeader so the example keeps compiling.
Add an integration test in crates/node/tests/it/rpc.rs that launches an OpNode against BASE_MAINNET and calls eth_config via the jsonrpsee HTTP client, verifying the endpoint is wired up.