Skip to content

test(op-reth): guard negotiated eth wire protocol version#20156

Open
joshklop wants to merge 1 commit intodevelopfrom
joshklop/osaka-7642
Open

test(op-reth): guard negotiated eth wire protocol version#20156
joshklop wants to merge 1 commit intodevelopfrom
joshklop/osaka-7642

Conversation

@joshklop
Copy link
Copy Markdown
Contributor

Add an integration test that spins up two op-reth nodes, lets them complete the devp2p handshake, and asserts the negotiated eth subprotocol version is exactly 69.

The test is intentionally written to fail when upstream reth bumps the negotiated version (e.g. to eth/70). That failure is the signal: it forces a conscious review of the new version's behavior before we ship it, rather than silently inheriting a protocol change on the next reth bump.

@joshklop joshklop requested a review from a team as a code owner April 18, 2026 13:28
@wiz-0f98cca50a
Copy link
Copy Markdown

wiz-0f98cca50a Bot commented Apr 18, 2026

Wiz Scan Summary

Scanner Findings
Vulnerability Finding Vulnerabilities 3 High 1 Medium 4 Low
Data Finding Sensitive Data -
Secret Finding Secrets -
IaC Misconfiguration IaC Misconfigurations -
SAST Finding SAST Findings -
Software Management Finding Software Management Findings -
Total 3 High 1 Medium 4 Low

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

@joshklop joshklop force-pushed the joshklop/osaka-7642 branch from d162129 to 6ffd544 Compare April 18, 2026 13:29
@joshklop joshklop linked an issue Apr 18, 2026 that may be closed by this pull request
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.5%. Comparing base (de1b557) to head (df233b7).

❗ There is a different number of reports uploaded between BASE (de1b557) and HEAD (df233b7). Click for more details.

HEAD has 13 uploads less than BASE
Flag BASE (de1b557) HEAD (df233b7)
cannon-go-tests-64 1 0
contracts-bedrock-tests 12 0
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #20156      +/-   ##
===========================================
- Coverage     75.8%     0.5%   -75.3%     
===========================================
  Files          183      486     +303     
  Lines        10536    61736   +51200     
===========================================
- Hits          7987      320    -7667     
- Misses        2405    61416   +59011     
+ Partials       144        0     -144     
Flag Coverage Δ
cannon-go-tests-64 ?
contracts-bedrock-tests ?
unit 0.5% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 669 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Add an integration test that spins up two op-reth nodes, lets them
complete the devp2p handshake, and asserts the negotiated eth
subprotocol version is exactly 69.

The test is intentionally written to fail when upstream reth bumps the
negotiated version (e.g. to eth/70). That failure is the signal: it
forces a conscious review of the new version's behavior before we ship
it, rather than silently inheriting a protocol change on the next reth
bump.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@joshklop joshklop force-pushed the joshklop/osaka-7642 branch from 6ffd544 to df233b7 Compare April 19, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Osaka on L2: add test for EIP 7642 (eth/69)

1 participant