test(op-reth): guard negotiated eth wire protocol version#20156
Open
test(op-reth): guard negotiated eth wire protocol version#20156
Conversation
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
d162129 to
6ffd544
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## develop #20156 +/- ##
===========================================
- Coverage 75.8% 0.5% -75.3%
===========================================
Files 183 486 +303
Lines 10536 61736 +51200
===========================================
- Hits 7987 320 -7667
- Misses 2405 61416 +59011
+ Partials 144 0 -144
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Add an integration test that spins up two op-reth nodes, lets them complete the devp2p handshake, and asserts the negotiated eth subprotocol version is exactly 69. The test is intentionally written to fail when upstream reth bumps the negotiated version (e.g. to eth/70). That failure is the signal: it forces a conscious review of the new version's behavior before we ship it, rather than silently inheriting a protocol change on the next reth bump. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
6ffd544 to
df233b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an integration test that spins up two op-reth nodes, lets them complete the devp2p handshake, and asserts the negotiated eth subprotocol version is exactly 69.
The test is intentionally written to fail when upstream reth bumps the negotiated version (e.g. to eth/70). That failure is the signal: it forces a conscious review of the new version's behavior before we ship it, rather than silently inheriting a protocol change on the next reth bump.