fix(op-reth): install rustls CryptoProvider before flashblocks TLS connection#20145
Open
clarkchen wants to merge 1 commit intoethereum-optimism:developfrom
Open
fix(op-reth): install rustls CryptoProvider before flashblocks TLS connection#20145clarkchen wants to merge 1 commit intoethereum-optimism:developfrom
clarkchen wants to merge 1 commit intoethereum-optimism:developfrom
Conversation
…nnection rustls 0.23+ requires an explicit `CryptoProvider` to be installed before any TLS operations. Without this, the flashblocks websocket connection (`wss://`) silently fails because `tokio-tungstenite` uses rustls under the hood but no crypto backend is configured. This adds `CryptoProvider::install_default(ring::default_provider())` early in main() before any TLS-dependent code runs. Fixes ethereum-optimism#19322
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rustls 0.23+requires an explicitCryptoProviderto be installedbefore any TLS
operations. Without this, the flashblocks wss:// connection silently
fails.
Adds
CryptoProvider::install_default(ring::default_provider())inmain().Fixes #19322
Context
PR #20027 addresses the same issue by adding
rustls-tls-native-rootstotokio-tungstenite, but the root cause is the missing crypto provider
initialization.