ci: route PR docker builds to tmp registry#20138
Open
falcorocks wants to merge 1 commit intodevelopfrom
Open
Conversation
Pull-request docker builds now push to a new ephemeral tmp Artifact Registry instead of the production images registry. Push-to-develop and scheduled builds continue to target images; releases via tags.yaml are unchanged. Closes #20137
raffaele-oplabs
approved these changes
Apr 17, 2026
Collaborator
raffaele-oplabs
left a comment
There was a problem hiding this comment.
Security review: approved.
This is the direct follow-up to ethereum-optimism/k8s#10613 (tmp registry creation) and #10614 (WIF write binding for this monorepo) — completing the PR-build isolation chain.
Verified:
- Diff is a surgical three-line ternary on
github.event_name:pull_requestpushes to the newtmpregistry, everything else (push to develop, scheduled, workflow_dispatch) keeps pushing toimages.tags.yamluntouched — tag/release builds remain onimages. - The
IMAGE:env ternary in the downstream run-image jobs preserves the existing fork split (build-fork.result == 'success'→ttl.shfor fork PRs) and only rewires the non-fork PR branch fromimagestotmp. Fork PRs never gain GCP auth via this change. github.event_nameis a trusted context value set by GitHub Actions — not user-influenceable. The image name (matrix.image_name) still comes from thedetect-changesaction driven by repo-localdocker-bake.hcl, so no injection surface.- CI already ran this config on this PR: the
attest build provenanceandbuild (…)jobs pushed tous-docker.pkg.dev/oplabs-tools-artifacts/tmp/<image>:<sha>and succeeded. Confirms the WIF binding from k8s#10614 works end-to-end. - Net effect: narrowing blast radius — untrusted-ish PR-branch builds no longer land in the production
imagesregistry. 30-day cleanup ontmpcaps persistence.
No new attack surface, no removed checks, no widened permissions.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #20138 +/- ##
==========================================
- Coverage 76.4% 76.2% -0.3%
==========================================
Files 187 187
Lines 10703 10703
==========================================
- Hits 8185 8159 -26
- Misses 2374 2400 +26
Partials 144 144
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Route pull-request docker builds to a new ephemeral
tmpArtifact Registry instead of the productionimagesregistry. Push-to-develop and scheduled builds still targetimages; tag/release builds (intags.yaml) are unchanged.Test plan
us-docker.pkg.dev/oplabs-tools-artifacts/tmp/<image>:<sha>--versiondeveloppush still targetsus-docker.pkg.dev/oplabs-tools-artifacts/imagesCloses #20137