feat: ban deposits client tests#11504
Merged
skeletor-spaceman merged 10 commits intofeat/ban-deposits-interopfrom Aug 29, 2024
Merged
feat: ban deposits client tests#11504skeletor-spaceman merged 10 commits intofeat/ban-deposits-interopfrom
skeletor-spaceman merged 10 commits intofeat/ban-deposits-interopfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/ban-deposits-interop #11504 +/- ##
=============================================================
- Coverage 78.10% 77.98% -0.12%
=============================================================
Files 28 29 +1
Lines 2137 2167 +30
=============================================================
+ Hits 1669 1690 +21
- Misses 407 413 +6
- Partials 61 64 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
skeletor-spaceman
force-pushed
the
feat/ban-deposits-tests
branch
from
57aa886 to
09411d3
Compare
…ism/optimism into feat/ban-deposits-tests
6 tasks
tynes
reviewed
Aug 23, 2024
tynes
reviewed
Aug 23, 2024
| // cast keccak $(cast concat-hex 0x0000000000000000000000000000000000000000000000000000000000000003 $(cast keccak 0x01)) | ||
| // # 0x8afb1c4a581d0e71ab65334e3365ba5511fb15c13fa212776f9d4dafc6287845 | ||
| func TestAfterForceIncludeSource(t *testing.T) { | ||
| source := AfterForceIncludeSource{ |
Contributor
There was a problem hiding this comment.
nit: this name is not consistent, its after force include, which iirc we moved away from
Collaborator
Author
There was a problem hiding this comment.
I think we agreed to go with AfterForceInclude, but I'm happy to re-name it to a better name :)
tynes
reviewed
Aug 23, 2024
tynes
reviewed
Aug 23, 2024
protolambda
reviewed
Aug 23, 2024
Comment on lines
+220
to
+224
| // sets config to post-interop | ||
| cfg.RegolithTime = &zero64 | ||
| cfg.EcotoneTime = &zero64 | ||
| cfg.InteropTime = &zero64 | ||
| cfg.BlockTime = 2 |
Contributor
There was a problem hiding this comment.
Bedrock, Canyon, Fjord, Granite are missing
protolambda
reviewed
Aug 23, 2024
Contributor
protolambda
left a comment
protolambda
left a comment
There was a problem hiding this comment.
Generally looks good. I think it would be nice to have a test helper-function to activate all hardforks in a rollup.Config up to and including a specific hardfork name. Then it's easier to prepare test cases for specific forks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
this PR is an extension of: #11362 please refer to it for additional context