feat: ban deposits interop#11451
Merged
skeletor-spaceman merged 20 commits intoethereum-optimism:feat/ban-deposits-interopfrom Aug 12, 2024
Merged
feat: ban deposits interop#11451skeletor-spaceman merged 20 commits intoethereum-optimism:feat/ban-deposits-interopfrom
skeletor-spaceman merged 20 commits intoethereum-optimism:feat/ban-deposits-interopfrom
Conversation
* refactor: not cross l2 inbox error
* refactor: not cross l2 inbox error
…nd/optimism into feat/ban-deposits-interop
* feat: add is deposit test
* fix: stick to natspec standards
This reverts commit e162361.
…mism/optimism into feat/ban-deposits-interop
* refactor: move the isthmus test logic to the l1 block test contract
* chore: remove unused imports
0xDiscotech
commented
Aug 12, 2024
Comment on lines
+124
to
+135
| /// @notice Updates the L1 block values for an Ecotone upgraded chain. | ||
| /// Params are packed and passed in as raw msg.data instead of ABI to reduce calldata size. | ||
| /// Params are expected to be in the following order: | ||
| /// 1. _baseFeeScalar L1 base fee scalar | ||
| /// 2. _blobBaseFeeScalar L1 blob base fee scalar | ||
| /// 3. _sequenceNumber Number of L2 blocks since epoch start. | ||
| /// 4. _timestamp L1 timestamp. | ||
| /// 5. _number L1 blocknumber. | ||
| /// 6. _basefee L1 base fee. | ||
| /// 7. _blobBaseFee L1 blob base fee. | ||
| /// 8. _hash L1 blockhash. | ||
| /// 9. _batcherHash Versioned hash to authenticate batcher by. |
Contributor
Author
There was a problem hiding this comment.
I opted to duplicate the NATSPEC on the public and the internal functions here. Lmk what do you think @skeletor-spaceman
0xDiscotech
commented
Aug 12, 2024
| } | ||
| } | ||
|
|
||
| contract L1BlockInteropIsDeposit_Test is L1BlockInteropTest { |
Contributor
Author
There was a problem hiding this comment.
I chose to create the test contract for each function just as other test files, even though they are not following that styling on this one. Lmk wdyt as well @skeletor-spaceman
skeletor-spaceman
merged commit 5e0d64c
into
ethereum-optimism:feat/ban-deposits-interop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
setValuesEcotone()from external to public._setValuesEcotone()function and used it on the public one.L1BlockInteropcontract.Tests
L1BlockInterop.t.solcontractAdditional context
#11362 (comment)