Open
Conversation
maurelian
approved these changes
Jul 17, 2025
| 2. **Validation Consolidation**: After the above, add `validate()` calls to OPCM's `deploy()` and `upgrade()` methods | ||
| 3. **Redundant Assertion Removal**: Remove duplicate validation logic from deploy scripts and other contracts, if they do not exist in the StandardValidator, they would be added to it. | ||
| 4. **Dispute Game Validation Enhancement**: Improve StandardValidator's dispute game validation logic | ||
| 5. **Remove proxyAdmin from OpChainConfig**: Remove the `proxyAdmin` field from the `OpChainConfig` struct used as input for `OPCM.upgrade()` |
Contributor
There was a problem hiding this comment.
Something to look into is if we could/should either:
- hardcode a default
prestateHash, or - pass in a single
prestateHashtoupgrade()/updatePrestate()` rather than including it in the array.
We should ask Proofs about this.
|
|
||
| ### 2. Validation Integration in OPCM Methods | ||
|
|
||
| Add `validate()` calls to OPCM's core methods: |
Contributor
There was a problem hiding this comment.
we need to ensure that this won't brick functions due to allowed config overrides. ie. if a chain has a different L1PAO, there will be a non-empty error string.
Contributor
Author
There was a problem hiding this comment.
Should there be support for overrides passed into upgrade, deploy functions?
|
|
||
| ### Resource Usage | ||
|
|
||
| - Running the StandardValidator's `validate()` function after upgrade or deploy functions might reduce the amount of these calls can be done within a block, though not by a significant amount. |
Contributor
There was a problem hiding this comment.
We should consider what the cost of running validate() is as it could limit how many upgrades we can do within a single transaction.
Contributor
Author
There was a problem hiding this comment.
yeah i will do this after the new assertions are added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add design doc for opcm improvements