Skip to content

Protect meta page when it's being written#1004

Closed
ahrtr wants to merge 1 commit intoetcd-io:mainfrom
ahrtr:20250626_meta
Closed

Protect meta page when it's being written#1004
ahrtr wants to merge 1 commit intoetcd-io:mainfrom
ahrtr:20250626_meta

Conversation

@ahrtr
Copy link
Copy Markdown
Member

@ahrtr ahrtr commented Jun 26, 2025

Followup to #989

We should protect the fdatasync as well.

cc @roman-khimov @Elbehery @fuweid @tjungblu

Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
@k8s-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr
Copy link
Copy Markdown
Member Author

ahrtr commented Jun 26, 2025

This PR isn't correct. It has two problem,

  • it may have big performance impact.
  • fdatasync is only related to data persistence. As long as we protect write and "read on mmap", it should be good.

@ahrtr ahrtr closed this Jun 26, 2025
@ahrtr ahrtr deleted the 20250626_meta branch June 26, 2025 11:12
@roman-khimov
Copy link
Copy Markdown
Contributor

fdatasync is only related to data persistence

Yes, disk/RAM sync is a different matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants