Skip to content

[release-1.3] Add template to cross arch build tests#1002

Merged
ahrtr merged 1 commit intoetcd-io:release-1.3from
Elbehery:20250625_1.3-use-temmplate-for-cross-build-tests
Jun 25, 2025
Merged

[release-1.3] Add template to cross arch build tests#1002
ahrtr merged 1 commit intoetcd-io:release-1.3from
Elbehery:20250625_1.3-use-temmplate-for-cross-build-tests

Conversation

@Elbehery
Copy link
Copy Markdown
Member

Backport of #999

cc @ahrtr @ivanvc

* Create a template to simplify executing tests without repetition.
* Run cross-compilation tests for Windows on Ubuntu (Linux), as every
  platform is being cross-compiled as a sanity check, it could also be
  done using Linux, and simplify the template.
* Remove the GolangCI lint action, as it is linting in Linux (as this is
  not using QEMU, but only cross-compilation), and there's no benefit to
  adding this step, as it's already checked in other workflows.

Signed-off-by: Ivan Valdes <ivan@vald.es>
Copy link
Copy Markdown
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Elbehery

Copy link
Copy Markdown
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @Elbehery.

@k8s-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ahrtr, Elbehery, ivanvc

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 014567e into etcd-io:release-1.3 Jun 25, 2025
35 checks passed
@Elbehery Elbehery deleted the 20250625_1.3-use-temmplate-for-cross-build-tests branch July 2, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants