feat(loadbalancer): Add LoadBalancerType Client Side Weighted Round Robin #7407
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,15 +11,17 @@ import gwapiv1 "sigs.k8s.io/gateway-api/apis/v1" | |
| // +union | ||
| // | ||
| // +kubebuilder:validation:XValidation:rule="self.type == 'ConsistentHash' ? has(self.consistentHash) : !has(self.consistentHash)",message="If LoadBalancer type is consistentHash, consistentHash field needs to be set." | ||
| // +kubebuilder:validation:XValidation:rule="self.type == 'ClientSideWeightedRoundRobin' ? has(self.clientSideWeightedRoundRobin) : !has(self.clientSideWeightedRoundRobin)",message="If LoadBalancer type is ClientSideWeightedRoundRobin, clientSideWeightedRoundRobin field needs to be set." | ||
| // +kubebuilder:validation:XValidation:rule="self.type in ['Random', 'ConsistentHash', 'ClientSideWeightedRoundRobin'] ? !has(self.slowStart) : true ",message="Currently SlowStart is only supported for RoundRobin and LeastRequest load balancers." | ||
| // +kubebuilder:validation:XValidation:rule="self.type in ['ConsistentHash', 'ClientSideWeightedRoundRobin'] ? !has(self.zoneAware) : true ",message="Currently ZoneAware is only supported for LeastRequest, Random, and RoundRobin load balancers." | ||
| type LoadBalancer struct { | ||
| // Type decides the type of Load Balancer policy. | ||
| // Valid LoadBalancerType values are | ||
| // "ConsistentHash", | ||
| // "LeastRequest", | ||
| // "Random", | ||
| // "RoundRobin", | ||
| // "ClientSideWeightedRoundRobin". | ||
| // | ||
| // +unionDiscriminator | ||
| Type LoadBalancerType `json:"type"` | ||
|
|
@@ -29,6 +31,12 @@ type LoadBalancer struct { | |
| // +optional | ||
| ConsistentHash *ConsistentHash `json:"consistentHash,omitempty"` | ||
|
|
||
| // ClientSideWeightedRoundRobin defines the configuration when the load balancer type is | ||
| // set to ClientSideWeightedRoundRobin. | ||
| // | ||
| // +optional | ||
| ClientSideWeightedRoundRobin *ClientSideWeightedRoundRobin `json:"clientSideWeightedRoundRobin,omitempty"` | ||
|
|
||
| // EndpointOverride defines the configuration for endpoint override. | ||
| // When specified, the load balancer will attempt to route requests to endpoints | ||
| // based on the override information extracted from request headers or metadata. | ||
|
|
@@ -51,7 +59,7 @@ type LoadBalancer struct { | |
| } | ||
|
|
||
| // LoadBalancerType specifies the types of LoadBalancer. | ||
| // +kubebuilder:validation:Enum=ConsistentHash;LeastRequest;Random;RoundRobin;ClientSideWeightedRoundRobin | ||
| type LoadBalancerType string | ||
|
|
||
| const ( | ||
|
|
@@ -63,6 +71,8 @@ const ( | |
| RandomLoadBalancerType LoadBalancerType = "Random" | ||
| // RoundRobinLoadBalancerType load balancer policy. | ||
| RoundRobinLoadBalancerType LoadBalancerType = "RoundRobin" | ||
| // ClientSideWeightedRoundRobinLoadBalancerType load balancer policy. | ||
| ClientSideWeightedRoundRobinLoadBalancerType LoadBalancerType = "ClientSideWeightedRoundRobin" | ||
| ) | ||
|
|
||
| // ConsistentHash defines the configuration related to the consistent hash | ||
|
|
@@ -134,6 +144,45 @@ type Cookie struct { | |
| Attributes map[string]string `json:"attributes,omitempty"` | ||
| } | ||
|
|
||
| // ClientSideWeightedRoundRobin defines configuration for Envoy's Client-Side Weighted Round Robin policy. | ||
| // See Envoy proto: envoy.extensions.load_balancing_policies.client_side_weighted_round_robin.v3.ClientSideWeightedRoundRobin | ||
|
Contributor
There was a problem hiding this comment. tbh https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/load_balancing_policies/client_side_weighted_round_robin/v3/client_side_weighted_round_robin.proto is not descriptive enough, and doesnt mention how this needs to be instrumented in the upstream, are there other links than can be used
Contributor
There was a problem hiding this comment. Yeah the docs aren't great... for example out-of-band reporting isn't supported at all yet reading the docs would indicate otherwise. We could contribute some docs changes upstream but agreed that including a reference to how
Contributor
Author
There was a problem hiding this comment. @arkodg what changes would you suggest me to add here? This is a bit more elaborative document https://docs.cloud.google.com/load-balancing/docs/https/applb-custom-metrics although this can also be confusing and gcp specific.
Contributor
There was a problem hiding this comment. do any docs exist that explain how a backend / server should be enhanced to send the appropriate trailors in the response ?
Contributor
Author
There was a problem hiding this comment. There is a google doc I will have to find it though but nothing stated officially as far I am aware of
Contributor
There was a problem hiding this comment. we should consider adding one if it doesnt exist There was a problem hiding this comment. Ack, this is good feedback on the docs gaps. I'll work with @efimki on this.
Contributor
There was a problem hiding this comment. thanks @AndresGuedez ! Happy to be the beta tester
Contributor
There was a problem hiding this comment. This is specific to google but some of their descriptions on ORCA/custom metrics may be helpful for the EG API fields - https://docs.cloud.google.com/load-balancing/docs/https/applb-custom-metrics#configure-custom-metrics That's not an explicit ask to make changes but give this a read. |
||
| // Note: SlowStart is not supported for this policy in Envoy Gateway at this time. | ||
| type ClientSideWeightedRoundRobin struct { | ||
altaiezior marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
altaiezior marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| // A given endpoint must report load metrics continuously for at least this long before the endpoint weight will be used. | ||
altaiezior marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| // Default is 10s. | ||
| // +optional | ||
| BlackoutPeriod *gwapiv1.Duration `json:"blackoutPeriod,omitempty"` | ||
|
|
||
| // If a given endpoint has not reported load metrics in this long, stop using the reported weight. Defaults to 3m. | ||
| // +optional | ||
| WeightExpirationPeriod *gwapiv1.Duration `json:"weightExpirationPeriod,omitempty"` | ||
|
|
||
| // How often endpoint weights are recalculated. Values less than 100ms are capped at 100ms. Default 1s. | ||
| // +optional | ||
| WeightUpdatePeriod *gwapiv1.Duration `json:"weightUpdatePeriod,omitempty"` | ||
|
|
||
| // ErrorUtilizationPenalty adjusts endpoint weights based on the error rate (eps/qps). | ||
| // This is expressed as a percentage-based integer where 100 represents 1.0, 150 represents 1.5, etc. | ||
| // | ||
| // For example: | ||
| // - 100 => 1.0x | ||
| // - 120 => 1.2x | ||
| // - 200 => 2.0x | ||
| // | ||
| // Note: In the internal IR/XDS configuration this value is converted back to a | ||
| // floating point multiplier (value / 100.0). | ||
jukie marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| // | ||
| // Must be non-negative. | ||
| // +kubebuilder:validation:Minimum=0 | ||
| // +optional | ||
| ErrorUtilizationPenalty *uint32 `json:"errorUtilizationPenalty,omitempty"` | ||
altaiezior marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| // Metric names used to compute utilization if application_utilization is not set. | ||
| // For map fields in ORCA proto, use the form "<map_field>.<key>", e.g., "named_metrics.foo". | ||
| // +optional | ||
| MetricNamesForComputingUtilization []string `json:"metricNamesForComputingUtilization,omitempty"` | ||
| } | ||
|
|
||
| // ConsistentHashType defines the type of input to hash on. | ||
| // +kubebuilder:validation:Enum=SourceIP;Header;Headers;Cookie | ||
| type ConsistentHashType string | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.