Skip to content

feat: Add WeightedZones to PreferLocalZones#7251

Merged
arkodg merged 19 commits intoenvoyproxy:mainfrom
jukie:api-weighted-zones
Feb 16, 2026
Merged

feat: Add WeightedZones to PreferLocalZones#7251
arkodg merged 19 commits intoenvoyproxy:mainfrom
jukie:api-weighted-zones

Conversation

@jukie
Copy link
Copy Markdown
Contributor

@jukie jukie commented Oct 16, 2025

What this PR does / why we need it:
Adds support for configuring zone weights which would be applied as localityLbConfig in lb policies that support it or localityWeightedLbConfig alongside ConsistentHashing lb policy.

Which issue(s) this PR fixes:

Fixes #5650

Release Notes: Yes

@jukie jukie marked this pull request as ready for review October 16, 2025 01:24
@jukie jukie requested a review from a team as a code owner October 16, 2025 01:24
@jukie jukie requested a review from a team October 16, 2025 01:24
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 16, 2025

Codecov Report

❌ Patch coverage is 96.49123% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.53%. Comparing base (38b0ad1) to head (fbf9a52).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/xds/translator/cluster.go 95.83% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7251      +/-   ##
==========================================
- Coverage   73.55%   73.53%   -0.03%     
==========================================
  Files         242      242              
  Lines       36949    37000      +51     
==========================================
+ Hits        27178    27208      +30     
- Misses       7851     7867      +16     
- Partials     1920     1925       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jukie
Copy link
Copy Markdown
Contributor Author

jukie commented Oct 16, 2025

/retest

1 similar comment
@jukie
Copy link
Copy Markdown
Contributor Author

jukie commented Oct 16, 2025

/retest

@jukie
Copy link
Copy Markdown
Contributor Author

jukie commented Oct 20, 2025

Bump here please

@jukie
Copy link
Copy Markdown
Contributor Author

jukie commented Oct 20, 2025

/retest

2 similar comments
@jukie
Copy link
Copy Markdown
Contributor Author

jukie commented Oct 21, 2025

/retest

@jukie
Copy link
Copy Markdown
Contributor Author

jukie commented Nov 19, 2025

/retest

@jukie jukie added this to the v1.7.0-rc.1 Release milestone Nov 27, 2025
@jukie
Copy link
Copy Markdown
Contributor Author

jukie commented Dec 2, 2025

Bump here

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 7, 2026

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

@netlify
Copy link
Copy Markdown

netlify bot commented Feb 6, 2026

Deploy Preview for cerulean-figolla-1f9435 ready!

Name Link
🔨 Latest commit fbf9a52
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/69927704df6abc00084bfc3a
😎 Deploy Preview https://deploy-preview-7251--cerulean-figolla-1f9435.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@jukie jukie changed the title API: Add WeightedZones to PreferLocalZones feat: Add WeightedZones to PreferLocalZones Feb 6, 2026
@jukie
Copy link
Copy Markdown
Contributor Author

jukie commented Feb 6, 2026

/retest

1 similar comment
@jukie
Copy link
Copy Markdown
Contributor Author

jukie commented Feb 7, 2026

/retest

jukie and others added 5 commits February 8, 2026 15:27
Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>
jukie and others added 4 commits February 10, 2026 08:23
Signed-off-by: Isaac Wilson <isaac.wilson514@gmail.com>
Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
@jukie jukie requested review from a team and arkodg February 12, 2026 00:17
arkodg
arkodg previously approved these changes Feb 14, 2026
Copy link
Copy Markdown
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@arkodg arkodg added this to the v1.8.0-rc.1 Release milestone Feb 14, 2026
@arkodg arkodg requested review from a team February 14, 2026 19:24
@jukie
Copy link
Copy Markdown
Contributor Author

jukie commented Feb 14, 2026

/retest

Signed-off-by: Isaac Wilson <isaac.wilson514@gmail.com>
@jukie
Copy link
Copy Markdown
Contributor Author

jukie commented Feb 15, 2026

/retest

@zirain
Copy link
Copy Markdown
Member

zirain commented Feb 16, 2026

/retest

@jukie
Copy link
Copy Markdown
Contributor Author

jukie commented Feb 16, 2026

/retest

@jukie
Copy link
Copy Markdown
Contributor Author

jukie commented Feb 16, 2026

@arkodg should I wait on #7407 before merging? #7407 (comment)

@arkodg
Copy link
Copy Markdown
Contributor

arkodg commented Feb 16, 2026

didnt see any changes being pushed on #7407, so lets get this in before that happens

@jukie
Copy link
Copy Markdown
Contributor Author

jukie commented Feb 16, 2026

/retest

@arkodg arkodg merged commit b4a0793 into envoyproxy:main Feb 16, 2026
120 of 129 checks passed
@jukie jukie deleted the api-weighted-zones branch February 16, 2026 19:30
Inode1 pushed a commit to Inode1/gateway that referenced this pull request Feb 23, 2026
* API: Add WeightedZones to PreferLocalZones

Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
antonio-mazzini pushed a commit to antonio-mazzini/gateway that referenced this pull request Mar 5, 2026
* API: Add WeightedZones to PreferLocalZones

Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Locality Weighted Load Balancing support

4 participants