Fix typos: occured -> occurred, propogate -> propagate#44077
Open
ctonneslan wants to merge 2 commits intoenvoyproxy:mainfrom
Open
Fix typos: occured -> occurred, propogate -> propagate#44077ctonneslan wants to merge 2 commits intoenvoyproxy:mainfrom
ctonneslan wants to merge 2 commits intoenvoyproxy:mainfrom
Conversation
5 instances across 5 files: - occured -> occurred in 3 log messages (http_capsule, upstream_request, http_datagram_handler) - propogate -> propagate in conn_manager.cc debug log - propogated -> propagated in mobile client.cc comment Skipped decorator_overriden_ variable name (breaking rename). Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
ctonneslan
requested review from
danzh2010,
mattklein123 and
zuercher
as code owners
ctonneslan
had a problem deploying
to
external-contributors
GitHub Actions
Error
|
Hi @ctonneslan, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
ctonneslan
requested a deployment
to
external-contributors
GitHub Actions
Waiting
Author
|
Good catch. Found one more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
4 typos across 4 files in log messages and comments:
Skipped the `decorator_overriden_` member variable in conn_manager_impl since renaming it would be a breaking change.