proto: Adds slow start config to wrr proto message#40090
proto: Adds slow start config to wrr proto message#40090wbpcode merged 4 commits intoenvoyproxy:mainfrom
Conversation
|
Hi @anuragagarwal561994, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: anurag.ag <anuragagarwal561994@users.noreply.github.com>
196dd87 to
ccd4f75
Compare
|
Related Proposal for GRPC Implementation: grpc/proposal#498 |
a1eb5ff to
db95123
Compare
Signed-off-by: anurag.ag <anuragagarwal561994@users.noreply.github.com>
db95123 to
cf7f22a
Compare
Signed-off-by: anurag.ag <anuragagarwal561994@users.noreply.github.com>
98e3419 to
a842318
Compare
|
I am OK to the API. But if we have no implementation for this, we may should mark it as unimplemented? /wait |
|
@wbpcode sure how do I mark it unimplemented, this is my first contribution here so need some help. I am also willing to add another MR for the same with the implementation of slow start config to client WRR, if possible please help me with how can I do the same. |
|
You could add But will prefer to wait the grpc/proposal#498 to be merged first. :) |
Signed-off-by: anurag.ag <anuragagarwal561994@users.noreply.github.com>
91cd6a0 to
464320b
Compare
|
@wbpcode I have made the respective changes to indicate this as unimplemented |
ping me at slack or github once the grpc approved your proposal. :) |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
@wbpcode can we re-open this MR, the proposal is ready and will be merged soon |
|
Instead of just slow_start_config, why don't we add the entire Round robin proto in here? that way you can pass the whole round robin proto to the underlying Round Robin LB that backs ClientSideWeightedRR. |
|
I think this can be done, if it will be easier to implement it in envoy what do you think @wbpcode |
|
friendly ping @wbpcode |
Commit Message: Adds support for slow_start config to client side wrr lb policy
Additional Description: Adds support in proto for slow start config for support in client side wrr for GRPC
Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A