Open
Conversation
|
The rendered spec for this PR is available at https://endojs.github.io/proposal-new-global/pr/9. |
kriskowal
reviewed
Jul 26, 2025
Comment on lines
+345
to
+346
| To apply isolation in bundles resulting from running a build process, while under CSP with no `unsafe-eval` we may need to rely on [Module Declarations](https://github.com/tc39/proposal-module-declarations) producing an instance or a `ModuleSource` whose import via an importHook by the new global would not be considered an evaluation but a same-origin import. | ||
| --- |
Member
There was a problem hiding this comment.
We do not need to wait for module declarations for CSP blessed module sources to come to bear. We already have that with import source and import.source, which if implemented by the host, may bless the module instance with origin information that would permit them to be executed under no-unsafe-eval. We also have to option of extending the ModuleSource constructor to accept a Trusted Type for the same effect.
Member
Author
There was a problem hiding this comment.
Delayed to after plenary, I don't know what I want this to say.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if it makes sense to have these for the meeting, but they exist.
@kriskowal Part of the writeup about inline modules under CSP may be incorrect. I need to improve my understanding of the relationship between ModuleSource and import and CSP