Skip to content

Modenization#12

Merged
emptymalei merged 3 commits intomainfrom
modenization
Aug 14, 2025
Merged

Modenization#12
emptymalei merged 3 commits intomainfrom
modenization

Conversation

@emptymalei
Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings August 14, 2025 09:53
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modernizes the Python package by migrating from setup.py-based configuration to Poetry's pyproject.toml format. The changes streamline dependency management and introduce modern development tooling.

Key changes:

  • Migrated from setup.py to Poetry configuration with pyproject.toml
  • Replaced requirements files with Poetry dependency groups
  • Added pre-commit hooks for code quality automation

Reviewed Changes

Copilot reviewed 10 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
setup.py Removed legacy setuptools configuration
requirements.extras.txt Removed in favor of Poetry dependency groups
pyproject.toml Added Poetry configuration with dependencies and build system
mkdocs.yml Updated mkdocstrings configuration for modern syntax
haferml/version.py Removed version file (now managed in pyproject.toml)
haferml/preprocess/pipeline.py Added new SimpleProcessor class and updated example call
haferml/preprocess/dataframe.py Added new DataFrame transformation classes
haferml/blend/config.py Added TrainConfig class for training configuration
haferml/init.py Removed version import
.pre-commit-config.yaml Added pre-commit configuration for code quality

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread haferml/blend/config.py

class TrainConfig:
"""Config for training stage
"""
Copy link

Copilot AI Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TrainConfig class docstring is incomplete. It should include parameter descriptions and usage examples for better API documentation.

Suggested change
"""
"""
TrainConfig manages configuration files for the training stage.
This class provides methods to initialize, read, update, and save configuration files used during training.
:param config_path: Path to the configuration file. Can be a local path or a cloud path.
:type config_path: AnyPath
Example usage:
>>> from haferml.blend.config import TrainConfig
>>> tc = TrainConfig("train_config.json")
>>> tc.init() # Initializes an empty config file
>>> tc.save({"lr": 0.001, "epochs": 10})
>>> print(tc.config)
{'lr': 0.001, 'epochs': 10}
>>> tc.update({"lr": 0.002})
>>> print(tc.config)
{'lr': 0.002, 'epochs': 10}
"""

Copilot uses AI. Check for mistakes.
@emptymalei emptymalei merged commit 9ae52c2 into main Aug 14, 2025
0 of 10 checks passed
@emptymalei emptymalei deleted the modenization branch August 14, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants