fix: correctly decode WSL2 Docker mounts#368
Open
yuvald-sweet-security wants to merge 1 commit intoeminence:masterfrom
Open
fix: correctly decode WSL2 Docker mounts#368yuvald-sweet-security wants to merge 1 commit intoeminence:masterfrom
yuvald-sweet-security wants to merge 1 commit intoeminence:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
My WSL2 installation with Docker Desktop has the following mount line, which causes this crate to panic:
C:\134Program\040Files\134Docker\134Docker\134resources /Docker/host 9p rw,noatime,aname=drvfs;path=C:\Program Files\Docker\Docker\resources;symlinkroot=/mnt/,cache=5,access=client,msize=65536,trans=fd,rfd=3,wfd=3 0 0(note that the spec field is correctly mangled, but the
pathmntop is not and has spaces, causing the split by space strategy to fail)Is this fix good? Do you prefer to do something else?