This repository was archived by the owner on Nov 7, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 82
Add support for storage options #68
Open
calintamas
wants to merge
5
commits into
emeraldsanto:master
Choose a base branch
from
amsterdam-platform-creation:feat-add-options
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5192241
feat: add support for kSecAttrAccessible options
calintamas deb459e
feat: add support for kSecAttrService and EncryptedSharedPreferences …
calintamas 4dcc1d6
chore: rename keychainAccessibility constant
calintamas 81725f9
docs: add storage options
calintamas 0fa74ff
fix: use only kSecClassGenericPassword unique key attributes on getItem
calintamas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
92 changes: 92 additions & 0 deletions
92
android/src/androidTest/java/com/emeraldsanto/encryptedstorage/MockReadableMap.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| package com.emeraldsanto.encryptedstorage; | ||
|
|
||
| import androidx.annotation.NonNull; | ||
| import androidx.annotation.Nullable; | ||
|
|
||
| import com.facebook.react.bridge.Dynamic; | ||
| import com.facebook.react.bridge.ReadableArray; | ||
| import com.facebook.react.bridge.ReadableMap; | ||
| import com.facebook.react.bridge.ReadableMapKeySetIterator; | ||
| import com.facebook.react.bridge.ReadableType; | ||
|
|
||
| import java.util.HashMap; | ||
| import java.util.Iterator; | ||
| import java.util.Map; | ||
|
|
||
| class MockReadableMap implements ReadableMap { | ||
| @Override | ||
| public boolean getBoolean(@NonNull String name) { | ||
| return false; | ||
| } | ||
|
|
||
| @Override | ||
| public double getDouble(@NonNull String name) { | ||
| return 0; | ||
| } | ||
|
|
||
| @Override | ||
| public int getInt(@NonNull String name) { | ||
| return 0; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean hasKey(@NonNull String name) { | ||
| return name.equals("storageName"); | ||
| } | ||
|
|
||
| @Override | ||
| public boolean isNull(@NonNull String name) { | ||
| return false; | ||
| } | ||
|
|
||
| @Nullable | ||
| @Override | ||
| public String getString(@NonNull String name) { | ||
| if (name.equals("storageName")) { | ||
| return "mock.storage.name"; | ||
| } | ||
| return null; | ||
| } | ||
|
|
||
| @Nullable | ||
| @Override | ||
| public ReadableArray getArray(@NonNull String name) { | ||
| return null; | ||
| } | ||
|
|
||
| @Nullable | ||
| @Override | ||
| public ReadableMap getMap(@NonNull String name) { | ||
| return null; | ||
| } | ||
|
|
||
| @NonNull | ||
| @Override | ||
| public Dynamic getDynamic(@NonNull String name) { | ||
| return null; | ||
| } | ||
|
|
||
| @NonNull | ||
| @Override | ||
| public ReadableType getType(@NonNull String name) { | ||
| return null; | ||
| } | ||
|
|
||
| @NonNull | ||
| @Override | ||
| public Iterator<Map.Entry<String, Object>> getEntryIterator() { | ||
| return null; | ||
| } | ||
|
|
||
| @NonNull | ||
| @Override | ||
| public ReadableMapKeySetIterator keySetIterator() { | ||
| return null; | ||
| } | ||
|
|
||
| @NonNull | ||
| @Override | ||
| public HashMap<String, Object> toHashMap() { | ||
| return null; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are not setting any default value for
options, nor checking if is it defined.This line throws if called without an
options, for example: