Fix pglite-socket maxConnections JSDoc default (1, not 100)#980
Merged
tdrz merged 1 commit intoelectric-sql:mainfrom May 6, 2026
Merged
Conversation
tdrz
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tiny one: fixes a stale JSDoc in
pglite-socket. The doc onPGLiteSocketServerOptions.maxConnectionsclaims(default: 100), but the constructor actually defaults to1. Three nearby spots agree the real default is1:src/index.ts:572—this.maxConnections = options.maxConnections ?? 1src/scripts/server.ts:67— CLI flagdefault: '1'src/scripts/server.ts:94— help text--max-connections=N ... (default is no concurrency: 1)#902 later locked in the same wording across the README, so
1is clearly the intended story — the JSDoc just needs to be brought up to speed, too. And both the docstring and the runtime default went in together in #873, so this is a same-PR typo rather than drift over time.To reproduce:
Hope it saves the next person a head-scratch.