Open
Conversation
Contributor
Author
|
I might have a better solution: generate a JSON |
jiribenes
commented
Apr 28, 2026
Comment on lines
279
to
285
| assembleJS := { | ||
| (Compile / clean).value | ||
| (Compile / compile).value | ||
| val jsFile = (Compile / fullOptJS).value.data | ||
| (Compile / fullLinkJS).value | ||
| val jsFile = (Compile / fullLinkJS / scalaJSLinkerOutputDirectory).value / "main.js" | ||
| val outputFile = (ThisBuild / baseDirectory).value / "out" / "effekt.js" | ||
| IO.copyFile(jsFile, outputFile) | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
this doesn't look like it actually embeds the stdlib-resources.json, we might need a bundler or also copy that file onto the website...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ScalaJS' pickler has some limit on string sizes which the recent stdlib additions changes overshoot by a lot on my computer.
This was preventing me from building the project locally.
The fix is horrible: we just chunk the string instead. Perhaps there's a better fix.We generate a
stdlib-resources.jsonfile which is then loaded by JS, thus removing the!!!MULTILINEMARKER!!!hack and generating huge Scala files altogether. :)This ought to:
be ported to(this ismillalso solvablesolved by Revert #1278 (Add build.mill setup) #1387)