Skip to content

Track depth of typed holes in lexer#1364

Open
LTeuse wants to merge 4 commits intomainfrom
fix/splice-brace
Open

Track depth of typed holes in lexer#1364
LTeuse wants to merge 4 commits intomainfrom
fix/splice-brace

Conversation

@LTeuse
Copy link
Copy Markdown
Contributor

@LTeuse LTeuse commented Apr 10, 2026

In Lexer, check if we are inside a hole before parsing }> to fix issue #1301.

Resolves #1301

Copy link
Copy Markdown
Contributor

@jiribenes jiribenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Please add a few tests into LexerTests:

test("interpolated hole string") {

(like the one from the issue)

I'm also very interested in nested holes like

<{ 
  val x = 42 + <" here's a string ">
  println(x)
  <>
}>

(and similar)

@jiribenes jiribenes changed the title add a check if we are in hole in Lexer/DepthTracker #1301 Track depth of typed holes in lexer #1301 Apr 10, 2026
@jiribenes jiribenes changed the title Track depth of typed holes in lexer #1301 Track depth of typed holes in lexer Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Greater-than sign after splice ending throws error

2 participants