Workaround poor reparse test performance and #1240

.github/workflows/ci-pr.yml

@@ -61,24 +61,6 @@ jobs:
       - name: Test effekt binary
         run: effekt.sh --help
 
-  # These are currently separated as they take a long time to run.
-  core-reparse-tests:
-    name: "Core Reparse Tests"
-    needs: build-and-compile
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v6
-        with:
-          submodules: 'true'
-
-      - uses: ./.github/actions/setup-effekt
-
-      - uses: ./.github/actions/restore-build-cache
-
-      - name: Run core reparse tests
-        run: |
-          sbt effektJVM/testCoreReparsing
-
   windows-tests:
     name: "Windows Smoke Test"
     needs: build-and-compile
@@ -102,7 +84,7 @@ jobs:
     runs-on: macos-latest
     steps:
       - uses: actions/checkout@v6
-        with: 
+        with:
           submodules: 'true'
 
       - uses: ./.github/actions/setup-effekt

build.sbt

@@ -17,7 +17,6 @@ lazy val bumpMinorVersion = taskKey[Unit]("Bumps the minor version number (used
 lazy val testBackendJS = taskKey[Unit]("Run JavaScript backend tests")
 lazy val testBackendChez = taskKey[Unit]("Run Chez Scheme backend tests")
 lazy val testBackendLLVM = taskKey[Unit]("Run LLVM backend tests")
-lazy val testCoreReparsing = taskKey[Unit]("Run core reparsing tests")
 lazy val testRemaining = taskKey[Unit]("Run all non-backend tests (internal tests) on effektJVM")
 
 lazy val noPublishSettings = Seq(
@@ -231,12 +230,6 @@ lazy val effekt: CrossProject = crossProject(JSPlatform, JVMPlatform).in(file("e
       ).value
     },
 
-    testCoreReparsing := {
-      (Test / testOnly).toTask(
-        " effekt.core.ReparseTests"
-      ).value
-    },
-
     testRemaining := Def.taskDyn {
       val log = streams.value.log
 
@@ -254,8 +247,7 @@ lazy val effekt: CrossProject = crossProject(JSPlatform, JVMPlatform).in(file("e
         "effekt.StdlibChezCPSTests",
         "effekt.LLVMTests",
         "effekt.LLVMNoValgrindTests",
-        "effekt.StdlibLLVMTests",
-        "effekt.core.ReparseTests",
+        "effekt.StdlibLLVMTests"
       )
 
       val remaining = allTests -- separatedTests

effekt/jvm/src/test/scala/effekt/core/ReparseTests.scala

@@ -49,9 +49,10 @@ class ReparseTests extends CoreTests {
     examplesDir / "pos" / "with_val_pair_and_else.effekt",
   )
 
+  // We currently only run reparse tests on the benchmarks rather than all positive examples.
+  // This is to save CI time as the core parser is currently very slow.
+  // This can be expanded later once we have better core frontend performance.
   def positives: Set[File] = Set(
-    examplesDir / "pos",
-    examplesDir / "casestudies",
     examplesDir / "benchmarks",
   )