Skip to content

Disallow block parameters on extern forever #1254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marvinborner wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Disallow block parameters on extern forever #1254

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion effekt/shared/src/main/scala/effekt/machine/Transformer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ object Transformer {

def transform(extern: core.Extern)(using BlocksParamsContext, ErrorReporter): Declaration = extern match {
case core.Extern.Def(name, tps, cparams, vparams, bparams, ret, capture, body) =>
if bparams.nonEmpty then ErrorReporter.abort("Foreign functions currently cannot take block arguments.")
if bparams.nonEmpty then ErrorReporter.abort("Foreign functions cannot take block arguments.")
Copy link
Copy Markdown
Contributor

@marzipankaiser marzipankaiser Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this error message will only show up on LLVM (i.e. machine-based backends), maybe we'd want to specify this in the error message?


val transformedParams = vparams.map(transform)
noteDefinition(name, transformedParams, Nil)
Expand Down