fix: proposal #1 votes not displaying due to missing vote_counts#221
Open
hopkdj wants to merge 1 commit into
Open
fix: proposal #1 votes not displaying due to missing vote_counts#221hopkdj wants to merge 1 commit into
hopkdj wants to merge 1 commit into
Conversation
- Add defensive null/undefined checks in votePercentage() function to handle proposals where vote_counts array is missing or malformed - Add safety checks in Proposals.vue before accessing vote_counts[1] and vote_counts[2] Fixes effectai#184
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The first proposal (#1) does not show votes even though they exist on the blockchain. This is caused by vote_counts being undefined or having a different structure for older proposals, which causes a JavaScript error when rendering the votes section.
Root Cause
Two places access vote_counts without null safety:
Fix
Fixes #184