feat(controller): wire GC scheduling to controller#2020
Open
feat(controller): wire GC scheduling to controller#2020
Conversation
Add GC job scheduling to the controller service. The controller periodically sweeps for locations with expired gc_manifest entries and dispatches GC jobs to workers via the job ledger. - Add GcSchedulingConfig (enabled/interval) to amp-config - Add locations_with_expired_entries() pre-filter query to metadata-db - Add schedule_gc_jobs() to controller scheduler with dedup, throttling, and per-location metrics - Spawn background scheduling task in controller service (disabled by default) - Add 4 scheduler integration tests (pre-filter, deactivated revisions, in-flight dedup, recently-completed throttle)
…iring # Conflicts: # crates/config/src/lib.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GcSchedulingConfig(enabled/interval) toamp-configwith TOML deserialization and JSON schemalocations_with_expired_entries()pre-filter query tometadata-db— single query returns only locations that need GCschedule_gc_jobs()to controller scheduler:gc_scheduling.enabled = false)Context
This is PR 3 of 3 splitting up the GC job extraction work:
amp-worker-gccrate (merged in feat(amp-worker-gc): add standalone GC job crate #2009)Wire to worker service (merged in feat(worker): wire GC job type to worker and admin-api #2010)