perf(worker-core): replace AsyncArrowWriter with parquet-ext#1852
Merged
JohnSwan1503 merged 13 commits intomainfrom Feb 25, 2026
Merged
Conversation
…rrowWriter is used. Signed-off-by: John Swanson <jswanson@edgeandnode.com>
\Replace the external git dependency on parquet-ext with a local workspace crate. The new crate provides a pipelined parquet writer with async support, row group encoding, progress tracking, and configurable writer properties. Update worker-core to use the new import path. Signed-off-by: John Swanson <jswanson@edgeandnode.com>
…writer-with-parquet-ext Signed-off-by: John Swanson <jswanson@edgeandnode.com>
Signed-off-by: John Swanson <jswanson@edgeandnode.com>
…r async operations Signed-off-by: John Swanson <jswanson@edgeandnode.com>
…to prevent deadlock on shutdown Signed-off-by: John Swanson <jswanson@edgeandnode.com>
…ltiple crates Signed-off-by: John Swanson <jswanson@edgeandnode.com>
… item management Signed-off-by: John Swanson <jswanson@edgeandnode.com>
…ered leaf collection Signed-off-by: John Swanson <jswanson@edgeandnode.com>
Signed-off-by: John Swanson <jswanson@edgeandnode.com>
Add crate README documenting architecture, usage, feature flags, performance characteristics, and configuration. Add two criterion benchmark suites comparing parquet-ext against Arrows built-in writer: arrow_writer (encoding microbenchmark) and end_to_end_writer (ful async pipeline). Export EncoderFactory from the public API to support the encoding benchmark. Signed-off-by: John Swanson <jswanson@edgeandnode.com>
format(benches): reorganize imports for better readability Signed-off-by: John Swanson <jswanson@edgeandnode.com>
Signed-off-by: John Swanson <jswanson@edgeandnode.com>
JohnSwan1503
deleted the
Swanson/worker-core/performance/replace-arrow-writer-with-parquet-ext
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new crate,
parquet-ext, and integrates it into the workspace, primarily to provide extended and async Parquet writing capabilities. The changes include adding the new crate, updating dependencies, and refactoring the codebase to use the new async Parquet writer implementation. The most significant changes are grouped below:1. Addition of the
parquet-extcrate:parquet-extwith support for async and zstd features, and implemented core modules for async Arrow writing, pipeline backends, and builder patterns. (crates/parquet-ext/Cargo.toml[1]crates/parquet-ext/src/arrow/async_writer/mod.rs[2]crates/parquet-ext/src/lib.rs[3] and related new files)2. Integration into workspace and dependencies:
crates/parquet-extin the workspace members and addedparking_lotas a workspace dependency. (Cargo.toml[1] [2]crates/core/worker-coreto depend on the newparquet-extcrate with async and zstd features, and switchedparking_lotto a workspace dependency. (crates/core/worker-core/Cargo.tomlcrates/core/worker-core/Cargo.tomlL20-R28)3. Refactoring to use the new async Arrow writer:
parquet::arrow::AsyncArrowWriterwithparquet_ext::arrow::async_writer::AsyncArrowWriterinparquet_writer.rs. (crates/core/worker-core/src/parquet_writer.rs[1] [2]4. Monitoring and logging updates:
parquet_extto the list of monitored crates in the logging configuration. (crates/core/monitoring/src/logging.rscrates/core/monitoring/src/logging.rsR99)5. Implementation details in
parquet-ext:crates/parquet-ext/src/writer/pipeline/encoder/batches.rs[1]crates/parquet-ext/src/backend/mod.rs[2]crates/parquet-ext/src/writer/pipeline/encoder/executor.rs[3]crates/parquet-ext/src/writer/pipeline/encoder/factory.rs[4]crates/parquet-ext/src/writer/pipeline/backend.rs[5]crates/parquet-ext/src/builder/mod.rs[6]These changes collectively introduce a new, extensible, and async-capable Parquet writing layer, and refactor the codebase to use this new implementation.