perf(extractors/solana): memory map CAR files for faster reading#1552
Merged
perf(extractors/solana): memory map CAR files for faster reading#1552
Conversation
LNSD
approved these changes
Jan 14, 2026
Contributor
LNSD
left a comment
LNSD
left a comment
There was a problem hiding this comment.
LGTM ✅
Please, check my comments 🙂
|
|
||
| let buf_reader = match tokio::fs::File::open(&dest).await.map(tokio::io::BufReader::new) { | ||
| Ok(reader) => reader, | ||
| let file = match std::fs::File::open(dest) { |
Contributor
There was a problem hiding this comment.
I would recommend using fs_err instead of std::fs for better error reporting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to give ~20% performance improvements on early epochs (up to ~50% with release builds!). Might be even more later on as the amount of data per epoch gets bigger since the improvements are additive.