Skip to content

Fix presign tests: use fake credentials instead of minio env vars #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
w4nderlust wants to merge 1 commit into
base: master
Choose a base branch
from

Fix presign tests: use fake credentials instead of minio env vars

181664d
Select commit
Loading
Failed to load commit list.
Open

Fix presign tests: use fake credentials instead of minio env vars #453

Fix presign tests: use fake credentials instead of minio env vars
181664d
Select commit
Loading
Failed to load commit list.
Brownian Motion v0 / Brownian Motion succeeded Apr 7, 2026 in 0s

PR effectively addresses test failures by using fake credentials.

Risk: Low · Confidence: 90%

Details

Brownian Motion (Brass)

Recommendation: Proceed

Summary: PR effectively addresses test failures by using fake credentials.
Risk: Low · Confidence: 90%

Highlights

  • Good test coverage
  • Clear commit history

Next actions

  • Keep: the new test helper for presign tests
  • Drop: reliance on external Minio instance for tests
  • Add: documentation on the new test structure

Reflection questions

  • What core assumption underpins this PR's approach?
  • How does this change align with the project's longer-term goals?
  • Could there be a simpler way to achieve the primary objective here?
View more details on Brownian Motion v0