Skip to content

Add support for AWS_CONTAINER_CREDENTIALS_FULL_URI (EKS Pod Identity Agent) #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LockedThread wants to merge 5 commits into
base: master
Choose a base branch
from

Add locks for token-env tests to remove chance of leaky tests

550f2c8
Select commit
Loading
Failed to load commit list.
Open

Add support for AWS_CONTAINER_CREDENTIALS_FULL_URI (EKS Pod Identity Agent) #449

Add locks for token-env tests to remove chance of leaky tests
550f2c8
Select commit
Loading
Failed to load commit list.
Brownian Motion v0 / Brownian Motion completed Mar 3, 2026 in 0s

PR adds support for EKS Pod Identity, but complexity may outweigh benefits.

Risk: Medium · Confidence: 70%

Details

Brownian Motion (Brass)

Recommendation: Refactor

Summary: PR adds support for EKS Pod Identity, but complexity may outweigh benefits.
Risk: Medium · Confidence: 70%

Highlights

  • Good test coverage
  • Clear documentation on changes

Unknowns

  • Impact on existing credential retrieval logic
  • Performance implications of added complexity

Next actions

  • Keep: Existing tests and documentation
  • Drop: Unused environment variable checks
  • Add: Simplified error handling for credential retrieval

Reflection questions

  • What core assumption underpins this PR's approach?
  • How does this change align with the project's longer-term goals?
  • Could there be a simpler way to achieve the primary objective here?
View more details on Brownian Motion v0