ui: remove dependency on qtwidgets for PasswordEdit box#119
Open
joshanne wants to merge 1 commit intodronecan:masterfrom
Open
ui: remove dependency on qtwidgets for PasswordEdit box#119joshanne wants to merge 1 commit intodronecan:masterfrom
joshanne wants to merge 1 commit intodronecan:masterfrom
Conversation
Qt6 isn't supported by the qtwidgets package. We only use qtwidgets for the PasswordEdit widget, so let's create our own internal version that makes use of qtawesome and exposes the same functionality.
Collaborator
Author
|
fyi @tpwrules |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm doing some ground work to upgrade gui_tool to Qt6.
Qt6 isn't supported by the qtwidgets package.
We only use qtwidgets for the PasswordEdit widget, so let's create our own internal version that makes use of qtawesome and exposes the same functionality.
This is to help minimize the changes being added when moving to Qt6 and avoid adding functionally new code in the migration process.
I'll have follow up PR shortly to move the project to Qt6. (See: Issue #107)