Open
Conversation
Adds instructions on how to install on macOS
joshanne
suggested changes
Jan 14, 2026
Collaborator
joshanne
left a comment
joshanne
left a comment
There was a problem hiding this comment.
I'd be happy to give an approval if this block is updated.
|
|
||
| Download macOS_DroneCAN_install.sh | ||
| Make it executable by navigating into the folder it is in (Downloads) and running: | ||
| ```chmod +x macOS_DroneCAN_install.sh |
Collaborator
There was a problem hiding this comment.
The markdown rendering on github makes this line invisible (see this permalink to the changes you've made).
You actually want this block to look like the following:
Suggested change
| ```chmod +x macOS_DroneCAN_install.sh | |
| ```bash | |
| chmod +x macOS_DroneCAN_install.sh | |
| ./macOS_DroneCAN_install.sh | |
| ``` |
joshanne
suggested changes
Mar 20, 2026
Collaborator
joshanne
left a comment
joshanne
left a comment
There was a problem hiding this comment.
Where is the macOS_DroneCAN_install.sh script located? It's not within this repo as far as I can tell - forgot to add before pushing?
That file should either:
- be self contained in this repo, accessible for review.
- or; we need to generate an installer for macOS files (I think it's dmg, if i'm not mistaken).
Happy to take a look at getting the build servers to handle this for us if we think it's necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds instructions on how to install on macOS