Skip to content

Fix: Add missing state_name and country_name columns to SQL Server CREATE TABLE schemas #1351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: master
from
Draft

Fix: Add missing state_name and country_name columns to SQL Server CREATE TABLE schemas #1351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e1c89f6
Initial plan
Copilot Feb 28, 2026
22f98bc
Initial plan: add missing state_name/country_name columns to SQL Serv…
Copilot Feb 28, 2026
e17b42b
Fix: add missing state_name and country_name columns to SQL Server CR…
Copilot Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions bin/Commands/ExportSqlServer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ private function generateTableSchema(string $table): string
name NVARCHAR(255) NOT NULL,
country_id INT NOT NULL,
country_code NCHAR(2) NOT NULL,
country_name NVARCHAR(255) NOT NULL,
fips_code NVARCHAR(255) NULL,
iso2 NVARCHAR(255) NULL,
iso3166_2 NVARCHAR(10) NULL,
Expand All @@ -126,8 +127,10 @@ private function generateTableSchema(string $table): string
name NVARCHAR(255) NOT NULL,
state_id INT NOT NULL,
state_code NVARCHAR(255) NOT NULL,
state_name NVARCHAR(255) NOT NULL,
country_id INT NOT NULL,
country_code NCHAR(2) NOT NULL,
country_name NVARCHAR(255) NOT NULL,
type NVARCHAR(191) NULL,
level INT NULL,
parent_id INT NULL,
Expand Down
6 changes: 3 additions & 3 deletions bin/db/schema.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@ DROP TABLE IF EXISTS `countries`;
DROP TABLE IF EXISTS `subregions`;
DROP TABLE IF EXISTS `regions`;

-- MySQL dump 10.13 Distrib 8.0.44, for Linux (x86_64)
-- MySQL dump 10.13 Distrib 8.0.45, for Linux (x86_64)
--
-- Host: localhost Database: world
-- ------------------------------------------------------
-- Server version 8.0.44-0ubuntu0.24.04.2
-- Server version 8.0.45-0ubuntu0.24.04.1

/*!40101 SET @OLD_CHARACTER_SET_CLIENT=@@CHARACTER_SET_CLIENT */;
/*!40101 SET @OLD_CHARACTER_SET_RESULTS=@@CHARACTER_SET_RESULTS */;
Expand Down Expand Up @@ -198,6 +198,6 @@ CREATE TABLE `cities` (
/*!40101 SET COLLATION_CONNECTION=@OLD_COLLATION_CONNECTION */;
/*!40111 SET SQL_NOTES=@OLD_SQL_NOTES */;

-- Dump completed on 2026-01-11 19:44:09
-- Dump completed on 2026-02-28 8:38:58

SET FOREIGN_KEY_CHECKS=1;