Skip to content

Implement a fast lookup for wildcard certificates #2815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arontsang wants to merge 7 commits into
base: main
Choose a base branch
from

Handle default certificate

d5a7a07
Select commit
Loading
Failed to load commit list.
Open

Implement a fast lookup for wildcard certificates #2815

Handle default certificate
d5a7a07
Select commit
Loading
Failed to load commit list.
Azure Pipelines / microsoft-reverse-proxy-ci failed Nov 12, 2025 in 12m 57s

Build #20251112.2 had test failures

6 errors / 5 warnings

Details

Tests

  • Failed: 6 (0.26%)
  • Passed: 2,203 (95.24%)
  • Other: 104 (4.50%)
  • Total: 2,313

Annotations

Check failure on line 2569 in test/ReverseProxy.Tests/Forwarder/HttpForwarderTests.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / microsoft-reverse-proxy-ci

test/ReverseProxy.Tests/Forwarder/HttpForwarderTests.cs#L2569 

test/ReverseProxy.Tests/Forwarder/HttpForwarderTests.cs(2569,51): error CS0121: (NETCORE_ENGINEERING_TELEMETRY=Build) The call is ambiguous between the following methods or properties: 'string.Join(string?, params string?[])' and 'string.Join(string?, params ReadOnlySpan<string?>)'

Check failure on line 0 in XUnit

See this annotation in the file changed.

@azure-pipelines azure-pipelines / microsoft-reverse-proxy-ci

XUnit#L0 

XUnit(0,0): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Tests failed: /home/vsts/work/1/s/artifacts/TestResults/Release/Yarp.Kubernetes.Tests_net8.0_x64.html [net8.0|x64]

Check failure on line 2569 in test/ReverseProxy.Tests/Forwarder/HttpForwarderTests.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / microsoft-reverse-proxy-ci

test/ReverseProxy.Tests/Forwarder/HttpForwarderTests.cs#L2569 

test/ReverseProxy.Tests/Forwarder/HttpForwarderTests.cs(2569,51): error CS0121: (NETCORE_ENGINEERING_TELEMETRY=Build) The call is ambiguous between the following methods or properties: 'string.Join(string?, params string?[])' and 'string.Join(string?, params ReadOnlySpan<string?>)'

Check failure on line 0 in XUnit

See this annotation in the file changed.

@azure-pipelines azure-pipelines / microsoft-reverse-proxy-ci

XUnit#L0 

XUnit(0,0): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Tests failed: /Users/runner/work/1/s/artifacts/TestResults/Release/Yarp.Kubernetes.Tests_net8.0_x64.html [net8.0|x64]

Check failure on line 1 in Yarp.Kubernetes.Tests.IngressCacheTests.SecretNotMatchDefaultNameIgnored

See this annotation in the file changed.

@azure-pipelines azure-pipelines / microsoft-reverse-proxy-ci

Yarp.Kubernetes.Tests.IngressCacheTests.SecretNotMatchDefaultNameIgnored 

Moq.MockException : 
Expected invocation on the mock should never have been performed, but was 1 times: h => h.ConvertCertificate(It.IsAny<NamespacedName>(), It.IsAny<V1Secret>())

Performed invocations:

   Mock<ICertificateHelper:17> (h):

      ICertificateHelper.ConvertCertificate(not-my-tls/yarp, V1Secret)
Raw output 
   at Moq.Mock.Verify(Mock mock, LambdaExpression expression, Times times, String failMessage) in C:\projects\moq4\src\Moq\Mock.cs:line 330
   at Moq.Mock`1.Verify[TResult](Expression`1 expression, Func`1 times) in C:\projects\moq4\src\Moq\Mock`1.cs:line 840
   at Yarp.Kubernetes.Tests.IngressCacheTests.SecretNotMatchDefaultNameIgnored() in /_/test/Kubernetes.Tests/IngressCacheTests.cs:line 164
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

Check failure on line 1 in Yarp.Kubernetes.Tests.IngressCacheTests.SecretNotMatchDefaultNameIgnored

See this annotation in the file changed.

@azure-pipelines azure-pipelines / microsoft-reverse-proxy-ci

Yarp.Kubernetes.Tests.IngressCacheTests.SecretNotMatchDefaultNameIgnored 

Moq.MockException : 
Expected invocation on the mock should never have been performed, but was 1 times: h => h.ConvertCertificate(It.IsAny<NamespacedName>(), It.IsAny<V1Secret>())

Performed invocations:

   Mock<ICertificateHelper:17> (h):

      ICertificateHelper.ConvertCertificate(not-my-tls/yarp, V1Secret)
Raw output 
   at Moq.Mock.Verify(Mock mock, LambdaExpression expression, Times times, String failMessage) in C:\projects\moq4\src\Moq\Mock.cs:line 330
   at Moq.Mock`1.Verify[TResult](Expression`1 expression, Func`1 times) in C:\projects\moq4\src\Moq\Mock`1.cs:line 840
   at Yarp.Kubernetes.Tests.IngressCacheTests.SecretNotMatchDefaultNameIgnored() in /_/test/Kubernetes.Tests/IngressCacheTests.cs:line 164
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

Check failure on line 1 in Yarp.Kubernetes.Tests.IngressCacheTests.SecretNotMatchDefaultNameIgnored

See this annotation in the file changed.

@azure-pipelines azure-pipelines / microsoft-reverse-proxy-ci

Yarp.Kubernetes.Tests.IngressCacheTests.SecretNotMatchDefaultNameIgnored 

Moq.MockException : 
Expected invocation on the mock should never have been performed, but was 1 times: h => h.ConvertCertificate(It.IsAny<NamespacedName>(), It.IsAny<V1Secret>())

Performed invocations:

   Mock<ICertificateHelper:12> (h):

      ICertificateHelper.ConvertCertificate(not-my-tls/yarp, V1Secret)
Raw output 
   at Moq.Mock.Verify(Mock mock, LambdaExpression expression, Times times, String failMessage) in C:\projects\moq4\src\Moq\Mock.cs:line 330
   at Moq.Mock`1.Verify[TResult](Expression`1 expression, Func`1 times) in C:\projects\moq4\src\Moq\Mock`1.cs:line 840
   at Yarp.Kubernetes.Tests.IngressCacheTests.SecretNotMatchDefaultNameIgnored() in /_/test/Kubernetes.Tests/IngressCacheTests.cs:line 164
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

Check failure on line 1 in Yarp.Kubernetes.Tests.IngressCacheTests.SecretNotMatchDefaultNameIgnored

See this annotation in the file changed.

@azure-pipelines azure-pipelines / microsoft-reverse-proxy-ci

Yarp.Kubernetes.Tests.IngressCacheTests.SecretNotMatchDefaultNameIgnored 

Moq.MockException : 
Expected invocation on the mock should never have been performed, but was 1 times: h => h.ConvertCertificate(It.IsAny<NamespacedName>(), It.IsAny<V1Secret>())

Performed invocations:

   Mock<ICertificateHelper:12> (h):

      ICertificateHelper.ConvertCertificate(not-my-tls/yarp, V1Secret)
Raw output 
   at Moq.Mock.Verify(Mock mock, LambdaExpression expression, Times times, String failMessage) in C:\projects\moq4\src\Moq\Mock.cs:line 330
   at Moq.Mock`1.Verify[TResult](Expression`1 expression, Func`1 times) in C:\projects\moq4\src\Moq\Mock`1.cs:line 840
   at Yarp.Kubernetes.Tests.IngressCacheTests.SecretNotMatchDefaultNameIgnored() in /_/test/Kubernetes.Tests/IngressCacheTests.cs:line 164
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
View more details on Azure Pipelines