dotnet test MTP: Support live output from test app processes#53495
Draft
Youssef1313 wants to merge 2 commits intorelease/10.0.3xxfrom
Draft
dotnet test MTP: Support live output from test app processes#53495Youssef1313 wants to merge 2 commits intorelease/10.0.3xxfrom
Youssef1313 wants to merge 2 commits intorelease/10.0.3xxfrom
Conversation
Youssef1313
force-pushed
the
dev/ygerges/redirect-mtp
branch
from
8f15e96 to
acc7282
Compare
This was referenced Mar 17, 2026
Youssef1313
commented
Mar 18, 2026
|
|
||
| private ProcessStartInfo CreateProcessStartInfo() | ||
| { | ||
| var shouldRedirect = _handler.ShouldRedirectOutputAndError; |
Member
Author
There was a problem hiding this comment.
This cannot work :/
We haven't started the process, so we don't know the protocol version or anything.
Looks like it's gonna be almost impossible to change this to avoid output/err redirection without being a big breaking change. 😕
Youssef1313
force-pushed
the
dev/ygerges/redirect-mtp
branch
from
4155c21 to
d59da55
Compare
Youssef1313
force-pushed
the
dev/ygerges/redirect-mtp
branch
from
d59da55 to
6086399
Compare
Youssef1313
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MTP side change is microsoft/testfx#7564
Fixes #51615
This needs manual validation that hasn't been done yet.