Fix CSharpSimplifyPropertyAccessorDiagnosticAnalyzer#82776
Open
DoctorKrolic wants to merge 3 commits intodotnet:mainfrom
Open
Fix CSharpSimplifyPropertyAccessorDiagnosticAnalyzer#82776DoctorKrolic wants to merge 3 commits intodotnet:mainfrom
CSharpSimplifyPropertyAccessorDiagnosticAnalyzer#82776DoctorKrolic wants to merge 3 commits intodotnet:mainfrom
Conversation
dotnet-policy-service
bot
added
Community
Contributor
Feel free to change teh testing harness to find and react to this. |
DoctorKrolic
changed the title
CSharpSimplifyPropertyAccessorDiagnosticAnalyzerCSharpSimplifyPropertyAccessorDiagnosticAnalyzer
...Sharp/Analyzers/SimplifyPropertyAccessor/CSharpSimplifyPropertyAccessorDiagnosticAnalyzer.cs
Outdated
Show resolved
Hide resolved
...Sharp/Analyzers/SimplifyPropertyAccessor/CSharpSimplifyPropertyAccessorDiagnosticAnalyzer.cs
Outdated
Show resolved
Hide resolved
This reverts commit 979b132.
JoeRobich
approved these changes
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #82739
It seems that
DiagnosticAnalyzerCategory.SyntaxTreeWithoutSemanticsAnalysiscan only register syntax tree actions and syntax node actions are considered semantic since their context also contains semantic information. This is super unintuitive so I fell for it when wrote the analyzer in the first place. It is also a shame that there was nothing stopping us from shipping completely broken analyzer to the prod. Manually verified that the issue is fixed with this changeMicrosoft Reviewers: Open in CodeFlow