Skip to content

Small optimization reducing repeated int.ToString calls in completion #82765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ToddGrun wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Small optimization reducing repeated int.ToString calls in completion #82765

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e0cf18
Small optimization reducing repeated int.ToString calls in completion
ToddGrun Mar 15, 2026
f4ba960
Push missed local commit switching to reference type for cache
ToddGrun Mar 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 29 additions & 1 deletion src/Features/Core/Portable/Completion/Providers/SymbolCompletionItem.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ internal static class SymbolCompletionItem

private static readonly Action<ImmutableArray<ISymbol>, ArrayBuilder<KeyValuePair<string, string>>> s_addSymbolEncoding = AddSymbolEncoding;
private static readonly Action<ImmutableArray<ISymbol>, ArrayBuilder<KeyValuePair<string, string>>> s_addSymbolInfo = AddSymbolInfo;
private static ContextPositionCache s_lastContextPositionInfo = new(0, "0");

private const char ProjectSeparatorChar = ';';

private static CompletionItem CreateWorker(
Expand Down Expand Up @@ -51,7 +53,7 @@ private static CompletionItem CreateWorker(
if (insertionText != null)
builder.Add(KeyValuePair.Create(InsertionTextProperty, insertionText));

builder.Add(KeyValuePair.Create("ContextPosition", contextPosition.ToString()));
AddContextPosition(builder, contextPosition);
AddSupportedPlatforms(builder, supportedPlatforms);
symbolEncoder(symbols, builder);

Expand Down Expand Up @@ -225,6 +227,26 @@ private static Document FindAppropriateDocumentForDescriptionContext(Document do
return document;
}

private static void AddContextPosition(ArrayBuilder<KeyValuePair<string, string>> properties, int contextPosition)
{
// Cache the last context position we added to avoid doing extra allocations of converting int to string.
// Nearly all completion items for a session have the same context position.
var contextPositionData = s_lastContextPositionInfo;

string contextPositionString;
if (contextPositionData.Position == contextPosition)
{
contextPositionString = contextPositionData.PositionString;
}
else
{
contextPositionString = contextPosition.ToString();
s_lastContextPositionInfo = new ContextPositionCache(contextPosition, contextPositionString);
}

properties.Add(KeyValuePair.Create("ContextPosition", contextPositionString));
}

private static void AddSupportedPlatforms(ArrayBuilder<KeyValuePair<string, string>> properties, SupportedPlatformData? supportedPlatforms)
{
if (supportedPlatforms != null)
Expand Down Expand Up @@ -406,4 +428,10 @@ public static async Task<CompletionDescription> GetDescriptionAsync(
return CompletionDescription.Empty;
}
}

private sealed class ContextPositionCache(int position, string positionString)
{
public readonly int Position = position;
public readonly string PositionString = positionString;
}
}
Loading